Thanks for pointing this out! I probably would have missed this, since I didn’t expect such a change for a patch release.
Their documentation mentions:
For jellyfin to know which reverse proxy is trusted, the IP, Hostname or Subnet has to be set in the Known Proxies (under Admin Dashboard -> Networking) setting.
Does this really mean, that the only way to configure this is through the web UI? This is kind of a problem when deploying it, since without the reverse proxy I can’t reach the Jellyfin server. Is there no way of doing this outside the web UI, via a config file or something?
sugar_in_your_tea@sh.itjust.works 3 days ago
It’s odd to throw that into a patch release. I guess we’ll find out if I did it correctly.
jonne@infosec.pub 3 days ago
I mean, it’s patching a security issue caused by trusting headers it shouldn’t, so I don’t think they should wait for a big number release.
sugar_in_your_tea@sh.itjust.works 3 days ago
Why wait? Just release it as a big number release. The version number doesn’t define the size or cadence of a release, it just says whether there’s a breaking change.
mac@lemm.ee 3 days ago
At least in my org we use semantic versioning ( Major.Minor.patch) where patch must either be a new feature, a fix, or something that is backwards compatible
N0x0n@lemmy.ml 3 days ago
I mean, where else should they show that warning? It’s also posted in the forum. They also edited the documentation page.
Maybe you’re more into mailing list or the like? I’m genuine curious on what and how you expected getting this kind of information.
fitgse@sh.itjust.works 3 days ago
I expect in a patch release that nothing has changed and I can blindly update getting minor bug fixes and security fixes. In a minor release I expect to review the changes for configuration changes or any minor UI changes. For a major release I expect to read docs on how to upgrade and prepare backups and downtime.
sugar_in_your_tea@sh.itjust.works 3 days ago
Exactly. It has nothing to do with where they post it, but what their version numbers communicate. I should be able to blindly apply patch releases, and this breaks that.
I’m even okay with a minor release here. It was never advertised to work that way so removing it technically isn’t a breaking change, but there is a known breakage here. I’m much more likely to read minor release notes than patch release notes, so I would likely see this warning if it was a minor release.
N0x0n@lemmy.ml 3 days ago
Ohhh thanks for the clarification ! As you guest I’m not into dev/programming so I wasn’t aware of this kind of detail !
Thank you :)