me_irl

Comments

• DieguiTux8623@feddit.it ⁨1⁩ ⁨year⁩ ago

  The worst case is when someone requires changes, you address them, but then they disappear/go on a leave.

  If the repository rules require all conversations to be resolved before merging and only the original reviewer can mark them as solved, the PR is stuck forever even if the rest of the team approves it.

  source

  • storcholus@feddit.de ⁨11⁩ ⁨months⁩ ago

    That sounds like something you bring up in the retro

    source

    • DieguiTux8623@feddit.it ⁨11⁩ ⁨months⁩ ago

      When the person came back from the leave I made some passive aggressive remark, hope this is enough 🤣

      source
  • Blamemeta@lemm.ee ⁨1⁩ ⁨year⁩ ago

    At that point, you get your team lead to go in the repo settings and unblock it.

    source
• AnarchoSnowPlow@midwest.social ⁨1⁩ ⁨year⁩ ago

  Also me waiting for the junior dev to address review comments satisfactorily.

  source

  • RagingRobot@lemmy.world ⁨11⁩ ⁨months⁩ ago

    Maybe offer to pair with them?

    source
• petey@aussie.zone ⁨1⁩ ⁨year⁩ ago

  Yeah, this is my colleagues waiting for me, poor batards

  source
• pimeys@lemmy.nauk.io ⁨1⁩ ⁨year⁩ ago

  A 15000 line PR landing on a Friday evening for the lucky random reviewer to open on Monday. “Please approve it fast so we avoid too many conflicts.”

  source
• friend_of_satan@lemmy.world ⁨1⁩ ⁨year⁩ ago

  I think my record is something like 6 years. I got a notification about it and thought my account had been hacked because I had no recollection of submitting a PR. Checked the PR description and it was definitely me.

  source
• Cheesebaron@feddit.dk ⁨1⁩ ⁨year⁩ ago

  This always happens to me when I’ve written some genius code. Takes so long to review it, because my caveman colleagues don’t understand it.

  source

  • nottheengineer@feddit.de ⁨1⁩ ⁨year⁩ ago

    If you wrote good code, even a caveman would understand it.

    source
  • Cheesebaron@feddit.dk ⁨11⁩ ⁨months⁩ ago

    It is amazing how many cavemen didn’t understand the sarcasm of my comment, and in their rage had to downvote it to hell. 😂

    source
  • 1984@lemmy.today ⁨11⁩ ⁨months⁩ ago

    With this attitude, the problem is you actually. Sorry.

    source