Comment

Comment on I wrote hacky tampermonkey script to fix Lemmy instance links. Any advice?

I just posted this on the post you linked, but yeah I am hardcoding a list of instances into my solution. Here’s my comment, copied:

I’m using the Firefox addon Redirector, and one of my rules there redirects community links using regex. I keep adding to the pattern as I encounter more instances. Currently it’s:

Pattern: https://(lemdro\.id|lemmy\.run|beehaw\.org|lemmy\.ml|sh\.itjust\.works|lemmy\.fmhy\.ml|lemmy\.dbzer0\.com|lemmy\.world|sopuli\.xyz|lemmy\.kde\.social|lemmygrad\.ml|mander\.xyz|lemmy\.ca|zerobytes\.monster)/c/(.*)

Redirect to: https://programming.dev/c/$2@$1

source

Sort:hotnew top

ezchili@iusearchlinux.fyi ⁨1⁩ ⁨year⁩ ago
Never use regex on URLs, make a list of hostnames and use the browser’s URL api to extract hostnames then match against the list

source
- Andy@programming.dev ⁨1⁩ ⁨year⁩ ago
  Can you provide an example URL that breaks this solution?
  
  source
  - ezchili@iusearchlinux.fyi ⁨1⁩ ⁨year⁩ ago
    Sure!
    
    user:pw@lemdro.id:80 is a valid url to lemdro.id and should match but will not
    
    maliciouswebsite.to/?q=http://lemdro.id will match but should not
    
    source
    Andy@programming.dev ⁨1⁩ ⁨year⁩ ago
    
    user:pw@lemdro.id:443 is a valid url to lemdro.id and should match but will not
    
    Well that one:
    
    technically shouldn’t match, because it’s not a community URL
    
    is not the form I expect and want to be using for this case
    
    may actually work (if it were a real community link, which again, it’s not), because after authentication I think the browser strips the credentials
    
    maliciouswebsite.to/?q=http://lemdro.id will match but should not
    
    No, it does not match.
    
    AFAICT, this solution is working properly, but if you can find a URL that breaks it, please let me know.
    
    source
    -> View More Comments
Turun@feddit.de ⁨1⁩ ⁨year⁩ ago
feddit.de is missing.

source
TerrorBite@meow.social ⁨1⁩ ⁨year⁩ ago
@Andy @BeanCounter Given how many of these start with "Lemmy" you could simplify this to:
`https://(lemmy\.(?:run|(?:fmhy\.)?ml|dbzer0\.com|world|kde\.social|ca)|lemmygrad\.ml|lemdro\.id|beehaw\.org|sh\.itjust\.works|(?:sopuli|mander)\.xyz|zerobytes\.monster)/c/(.*)`
Or just assume that anything matching `https://(lemmy\.[^/]+)/c/(.*)` is a Lemmy server, which will probably be correct.
source