Comment on I wrote hacky tampermonkey script to fix Lemmy instance links. Any advice?
Andy@programming.dev 1 year agouser:pw@lemdro.id:443 is a valid url to lemdro.id and should match but will not
Well that one:
- technically shouldn’t match, because it’s not a community URL
- is not the form I expect and want to be using for this case
- may actually work (if it were a real community link, which again, it’s not), because after authentication I think the browser strips the credentials
maliciouswebsite.to/?q=http://lemdro.id will match but should not
No, it does not match.
AFAICT, this solution is working properly, but if you can find a URL that breaks it, please let me know.
ezchili@iusearchlinux.fyi 1 year ago
Lmao ok
Andy@programming.dev 1 year ago
I’m not trying to be combative, I’m trying to understand. I’d like to see the failure in action so I can appreciate and pursue the proposed solution.
But when I added the community bit to the first URL, the browser resolved it and stripped the credentials, so the resulting URL matched. But the example credentials weren’t real so it’s not a great test; if there’s an real example I can test, please share it. Though I don’t see why I’d auth to an instance just to view it from a different instance.
When I added the community bit to the second URL, it was not a match, as it shouldn’t be. The pattern must match the entire URL.
ezchili@iusearchlinux.fyi 1 year ago
You can find it in action on regex101
Just the port is enough to make it fail but this is not even the point
The sheer number of things you have to take into account to properly parse a URL should convince you to not use regexes for it
Andy@programming.dev 1 year ago
I meant to communicate that the Redirector addon uses the given pattern to see if the entire URL string matches, not part of it. So the malicious URL does not match.
I’m wondering if there’s a real URL for which the Redirector approach will not work.