Comment on GitHub - LadybirdBrowser/ladybird: Truly independent web browser

• sugar_in_your_tea@sh.itjust.works ⁨1⁩ ⁨month⁩ ago

  True, but that only applies if it’s misleading. For example:

  // pythagoran theorem 
  distance = abs(p2.x - p1.x) + abs(p2.y - p1.y); 
  

  Fixing that makes sense because it’s wrong and misleading (it’s actually Manhattan distance), and a quick glace is insufficient to tell the difference.

  But fixing a typo or something that wouldn’t be confusing is just noise and should only be fixed with other changes. For example, I intentionally misspelled Pythagorean in my comment above, fixing that to be the right spelling would be a useless change, even if the distance formula used the hypotenuse. It wouldn’t be an unreasonable policy to reject PRs that only fix spelling to reduce noise for the maintainers.

  source

  • surewhynotlem@lemmy.world ⁨1⁩ ⁨month⁩ ago

    Yep, I understand but disagree. Maybe it comes from working with so many ESL coders, but I’ll happily accept typo corrections because it’s not always obvious what words should be if you’re not steeped in the culture.

    source

    • sugar_in_your_tea@sh.itjust.works ⁨1⁩ ⁨month⁩ ago

      It really depends on the project.

      If you’re a larger project, you can see a ton of these from people hoping to land a commit to put “contributor to X” on a resume somewhere. Those add up and are really distracting and possibly automated.

      If you’re a smaller project, it doesn’t matter as much. I work with ESL coders too, so I get it (1/4 of my office is ESL immigrants, and ~2/3 of the broader team is ESL). I fix comments all the time, I just include them with other changes.

      So it depends. But in general, a high profile project should reject this noise to discourage this behavior.

      source

      • pogmommy@lemmy.blahaj.zone ⁨1⁩ ⁨month⁩ ago

        In theory that’s fair reasoning. Unfortunately the dev made it clear that his reasoning was based on politics

        source

        • -> View More Comments