Comment on Is there a place where you can request code reviews on opensource software?

• kassuro@feddit.de ⁨11⁩ ⁨months⁩ ago

  Would love something like this, but it’s very hard to get such a community working. Most of the time there will be way more people wanting a review of their code than people wanting to put in the work and review something.

  Maybe some kind of point system could work. Like one needs to review at least two times before you can get your work reviewed.

  source

  • lhamil64@programming.dev ⁨11⁩ ⁨months⁩ ago

    One issue I can see with the points system is that people could just approve it with a “Looks good to me!” without even looking at the code. Or just looking at a small portion of the code.

    source

    • coloredgrayscale@programming.dev ⁨11⁩ ⁨months⁩ ago

      Also bike shedding. Simple stuff may get many people willing to review / argue about how you should have used A over B, or even C

      Big / complicated projects - forget it. Especially if if they would need major refactoring.

      source
    • threelonmusketeers@sh.itjust.works ⁨11⁩ ⁨months⁩ ago

      Could there be a way to award the points proportionally, based on how useful the feedback is?

      source

      • kassuro@feddit.de ⁨11⁩ ⁨months⁩ ago

        But who decides that? If the person who requested it can do this, you only need a friend to abuse the system and give each other a few extra points.

        Maybe a open point history could help with this and users moderate themselves with this.

        source
    • kassuro@feddit.de ⁨11⁩ ⁨months⁩ ago

      Yeah that’s definitely a possibility. It’s really a tricky topic to build a review community. One could try other approaches like dedicated volunteer reviewers. But if you look at exorcism, that will become hard to manage for languages with huge demand.

      A system where everyone also needs to review is definitely better. Especially since everyone also learns reading other peoples code.

      source
  • Ategon@programming.dev ⁨11⁩ ⁨months⁩ ago

    with that there would need some way for people to have things to initially review to get the community started. Could do something like after the first 3 posts the point system goes into effect

    source

    • kassuro@feddit.de ⁨11⁩ ⁨months⁩ ago

      True, it’s not a fleshed out idea haha. But starting with a few points would work.

      Could actually be a cool in it self, wish I had time for something like that.

      source

      • vrek@programming.dev ⁨11⁩ ⁨months⁩ ago

        Something like c sharp acedemy would be kinda cool. Basically do some beginner projects with good code reviews you get a “belt”. That belt allows you to review the beginner projects as you work on intermediate projects. Then you complete those and get another belt that let’s you do advanced projects and review the intermediate projects others submitted.

        source
    • subignition@kbin.social ⁨11⁩ ⁨months⁩ ago

      Kinda sounds like a format similar to Stack Exchange might work

      source

      • RoToRa@discuss.tchncs.de ⁨11⁩ ⁨months⁩ ago

        There actually is a Stack Exchange community for code reviews: codereview.stackexchange.com

        source