Comment

Comment on Is there a place where you can request code reviews on opensource software?

stifle867@programming.dev ⁨11⁩ ⁨months⁩ ago

This is not an answer to your question but it’s tangentially related.

Someone I greatly respected ran an open-source project with the policy of merge everything. Completely flip this idea of carefully review, debate and revise every PR. His theory was that it helps to build an open community, and if something breaks someone else will revert that commit. He says that the main branch was almost always stable, a massive improvement to how it was run previously. He passed several years ago and for some reason this reminded me of him.

I guess what I’m trying to say is if you get something out there that people find useful, the code will be looked at. It doesn’t help you if you’re looking for someone to collaborate sorry.

source

Sort:hotnew top

treadful@lemmy.zip ⁨11⁩ ⁨months⁩ ago
This is how you get supply chain attacks.

source
- stifle867@programming.dev ⁨11⁩ ⁨months⁩ ago
  Yes it is. The code is in Bitcoin Core so there’s a non-zero chance you win at life if you want to try.
  
  source
varsock@programming.dev ⁨11⁩ ⁨months⁩ ago
There is a very effective approach (34:00), that big companies like cloudflare use, to ship a product in a fast and quality way. It bears parallels to what you are describing

Just build a proof of concept
source
jeremyparker@programming.dev ⁨11⁩ ⁨months⁩ ago
That’s Wikipedia’s approach, arguably one of the most successful “open source” projects in history - certainly not without its problems, but overall it’s pretty great

source
varsock@programming.dev ⁨11⁩ ⁨months⁩ ago
I’ve actually found his blog where he talks about this “optimistic merge”

hintjens.com/blog:106

source
- stifle867@programming.dev ⁨11⁩ ⁨months⁩ ago
  There’s a number of them as the idea grows. See also the C4 process RFC
  
  source
  - lysdexic@programming.dev ⁨11⁩ ⁨months⁩ ago
    
    See also the C4 process RFC
    
    What an unfortunate name.
    
    c4model.com
    
    source
  - onlinepersona@programming.dev ⁨11⁩ ⁨months⁩ ago
    mbin (fork of kbin) is currently trying to implement the process.
    
    source
    stifle867@programming.dev ⁨11⁩ ⁨months⁩ ago
    It’s great to see the attempt and also an example of what the C4 guidelines are made to avoid.
    
    Notice how many comments are little nitpicks about this and that. Completely stalling the commit and getting further away from the original point of C4 which is to reduce contributor friction and avoid these kind of endless discussions on PRs.
    
    I don’t want to be too critical because some of that is a clear lack of understanding of the motivations of C4 which is explained more thoroughly in Pieter’s blog posts. You don’t want to adopt a contributor guidelines that you don’t understand of course.
    
    IMO it’s better just to implement it as-is and start using it in practice rather than bikeshedding.
    
    source
    -> View More Comments
attn_dfct_dev@programming.dev ⁨11⁩ ⁨months⁩ ago
This is for 0mq right? I remember reading Pieter Hintjens about this realization he had over a long time of developing 0mq.

source
- stifle867@programming.dev ⁨11⁩ ⁨months⁩ ago
  Yes that’s right. I was only just transitioning into adulthood and Pieter mentored me and profoundly changed how I view many things. It wasn’t just zeromq but that was the main thing. I still keep his books at hand on my bookshelf. His death impacted me greatly.
  
  Image
  
  source