Comment

GenosseFlosse@feddit.org ⁨5⁩ ⁨months⁩ ago

You never worked onrold code. It’s never that simple in practice when you have to make changes to existing code without breaking or rewriting everything.

Sometimes the client wants a new feature that cannot easily implement and has to do a lot of different DB lookups that you can not do in a single query. Sometimes your controller loops over 10000 DB records, and you call a function 3 levels down that suddenly must spawn a new DB query each time it’s called, but you cannot change the parent DB query.

source

Sort:hotnew top

fluckx@lemmy.world ⁨5⁩ ⁨months⁩ ago
Where is this even coming from? The guy above me is saying not to give devs better hardware and to teach them to code better.

I followed up with an example of how using indices in a database to boost the performance helped more than throwing more hardware at it.

This has nothing to do with having worked on old code. Stop trying to pull my comment out of context.

But yes you’re right. Adding indexes to a database does nothing to solve adding a new feature in the scenario you described. I also never claimed it did.

source
sugar_in_your_tea@sh.itjust.works ⁨5⁩ ⁨months⁩ ago
but you cannot change the parent DB query.

Why not?

This sounds like the “don’t touch working code” nonsense I hear from junior devs and contracted teams. They’re so worried about creating bugs that they don’t fix larger issues and more and more code gets enshrined as “untouchable.” IMO, the older and less understood logic is, the more it needs to be touched so we can expose the bugs.

Here’s what should happen, depending on when you find it:

grooming/research phase - increase estimates enough to fix it

development phase - ask senior dev for priority; most likely, you work around for now, but schedule a fix once feature compete; if it’s significant enough, timelines may be adjusted

testing phase/hotfix - same as dev, but much more likely to put it off

Teams should have a budget for tech debt, and seniors can adjust what tech debt they pick.
source
- lightnegative@lemmy.world ⁨5⁩ ⁨months⁩ ago
  “Don’t touch working code” stems from “last person who touched it, owns it” and there’s some shit that it’s just not worth your pay grade to own.
  
  Particularly if you’re a contractor employed to work on something specific
  
  source
  - sugar_in_your_tea@sh.itjust.works ⁨5⁩ ⁨months⁩ ago
    I get that for contractors, get in and get out is the best strategy.
    
    If you’re salary, you own it regardless, so you might as well know what it does.
    
    source
- ieGod@lemmy.zip ⁨5⁩ ⁨months⁩ ago
  That budget is the key. You have to demonstrate/convince the purse holders first. This isn’t always an easy task.
  
  source
  - sugar_in_your_tea@sh.itjust.works ⁨5⁩ ⁨months⁩ ago
    Fair. If that’s not possible, I’ll start looking for another job, because I don’t want to deal with a time bomb that will suddenly explode and force me to come in on a holiday of something to fix it. My current company allocates 10-20% of dev time to tech debt, because we all know it’ll happen, so we budget for it.
    
    source
PattyMcB@lemmy.world ⁨5⁩ ⁨months⁩ ago
That’s why it needs to be written better in the first place

source
- GenosseFlosse@feddit.org ⁨5⁩ ⁨months⁩ ago
  Tell me you never worked on legacy code without telling me…
  
  source
  - PattyMcB@lemmy.world ⁨5⁩ ⁨months⁩ ago
    Kid. Go away
    
    source
    Womble@piefed.world ⁨5⁩ ⁨months⁩ ago
    You do accept that bad software has been written, yes? and that some of that software is performing important functions? So how is saying "It needs to be written better in the first place" of any use at all when discussing legacy software?
    
    source
    -> View More Comments