Regarding the “bad code”. It’s more readable though to keep the full limit for each elif case, which is most often way more important than performance, especially since than logic with the age can be easily optimized by any good compiler or runtime.
Comment on ChatGPT advises women to ask for lower salaries, study finds
BassTurd@lemmy.world 3 days agoApart from the bias, that’s just bad code. Since else if executes in order and only continues if the previous block is false, the double compare on ages is unnecessary. If age <= 18 is false, then the next line can just be, else if age <= 30. No need to check if it’s also higher than 18.
This is first semester of coding and any junior dev worth a damn would write this better.
But also, it’s racist, which is more important, but I can’t pass up an opportunity to highlight how shitty AI is.
Lifter@discuss.tchncs.de 1 day ago
BassTurd@lemmy.world 23 hours ago
Code readability is important, but in this case I find it less. In every language I’ve studied, it’s always taught to imply the previous condition, and often times I hear or read that explicitly stated. When someone writes code that does things differently than the expectation, it can make it more confusing to read. It took me longer to interpret what was happening because what is written breaks from the norm.
Past readability, this code is now more difficult to maintain. If you want to change one of the dates ranges, the code has to be updated in two places rather than one. The changes are difficult, but it would be easy to miss since this isn’t how elif should be written.
Lastly, this block of code is now half as efficient. It takes twice as many compares to evaluate the condition. This isn’t a complicated block of code, so it’s negligible, but if this same practice were used in something like a game engine where that block loops continuously, the small inefficiencies can compound
Lifter@discuss.tchncs.de 4 hours ago
Good points! Keeping to the norm is very important for readability.
I do disagree with the performance bit though. Again, there will probably be no difference at all in the performance because the redundant code is removed before (or during [e.g. JIT optimizations]) execution.
CosmicTurtle0@lemmy.dbzer0.com 3 days ago
Honestly it’s a bit refreshing to see racism and ageism codified. Before there was no logic to it but now, it completely makes sense.
napkin2020@sh.itjust.works 3 days ago
Yeah, more and more I notice that at the end of the day, what they spit out without(and often times, even with) any clear instructions is barely a prototype at best.
ninjakttty@lemmy.world 3 days ago
I can excuse racism but I draw the line at bad code.