Comment

Comment on Windows feature that resets system clocks based on random data is wreaking havoc

Z4rK@lemmy.world ⁨10⁩ ⁨months⁩ ago

While the root issue was still unknown, we actually wrote one. It sort of made sense. Check that the date from isn’t later than date to in the generated range used for the synchronization request. Obviously.

However, it was far worse to write the code that fulfilled the test. In the very same free lines of code, we fetched the current date from time.now() plus some time span as date to, fetched the last synchronization timestamp from db as date from, and then validated that date from wasn’t greater than date to, and if so, log an error about it.

The validation code made no logic sense when looking at it.

source

Sort:hotnew top

SzethFriendOfNimi@lemmy.world ⁨10⁩ ⁨months⁩ ago
Feels like writing

Assert.is(false,“This should never happen”);

and seeing it pop up one time?

source
towerful@programming.dev ⁨10⁩ ⁨months⁩ ago
I feel like the 3rd party API should have had some error checking, although that might have strayed too far into a client’s business logic.
If it is an API of incidents, that suggests past incidents. And the whole “never trust user data” kinda implies they should throw an error if you request information about a tinerange in the future.
I guess, not throwing an error does allow the 3rd party to “schedule” an incident in the future, eg planned maintenance/downtime.

But then, that isn’t separation of concerns. Ideally those endpoint would be separate. One for planned hypothetical incidents and one for historical concrete incidents.

It’s definitely an odd scenario where you are taking your trusted data (from your systems and your database), then having to validate it.

source