Comment - FBXL Lotide

Comment on Partially incorrect MIME type detection for files newly uploaded to the cloud

What could be done to ensure that CSS is recognised correctly and entered into the table?

Maybe file an issue to libmagic?

I would rather not rely on file endings to determine the file mime type. We could possibly make an excemption for channels that have code right so that in that case if text/plain is returned from finfo() we compare it to the previously provided mimetype and if it is not the same, revert to the provided one. But i actually do not like this hack!

original

Sort:hotnew top

abu@hub.alfredbuehler.ch ⁨6⁩ ⁨days⁩ ago
@Mario Vavti
But i actually do not like this hack!

I wouldn't like it either. But what are the chances that it will be fixed in libmagic within a reasonable timespan? Forget it; we need a usable workaround for the Hubzilla webpages ASAP.
original
- pepecyb@hub.hubzilla.hu@hub.hubzilla.hu ⁨6⁩ ⁨days⁩ ago
  I don’t see any chance of a fix for libmagic either. Particularly because the repository isn’t really very accessible.
  My suggestion would be:
  
  // Until here we either used the provided mime type or set mimetype by extension. // Both variants are inherently unsafe hence try to find and set the real mimetype before storage. if (class_exists('finfo') && is_file($os_basepath . $os_relpath)) { $finfo = new finfo(FILEINFO_MIME_TYPE); $mimetype = $finfo->file($os_basepath . $os_relpath); if ($mimetype === false) { $mimetype = 'application/octet-stream'; } // Workaround for libmagic misidentifying CSS files as text/plain if ($mimetype === 'text/plain' && preg_match('/\.css$/i', $os_relpath)) { $mimetype = 'text/css'; } }
  
  This is harmless, only affects CSS and should sort out the problem.
  original
  - abu@hub.alfredbuehler.ch ⁨6⁩ ⁨days⁩ ago
    @Der Pepe (Hubzilla) ⁂
    if ($mimetype === 'text/plain' && preg_match('/.css$/i', $os_relpath))
    
    Sorry, but this won't work, as $os_rel_path is the hash, rather than the filename.
    
    $os_basepath = "store/abu/", $os_relpath = "187613e5-2220-4a71-85c1-f6bff4325a39"
    original
    pepecyb@hub.hubzilla.hu@hub.hubzilla.hu ⁨6⁩ ⁨days⁩ ago
    That’s right, unfortunately… it should be $filename instead of $os_relpath, so
    
    if ($mimetype === “text/plain” && preg_match(“/.css$/i”, $filename))
    
    Is that correct?
    original
    -> View More Comments