martin

@martin@meta.discourse.org

This is a remote user, information on this page may be incomplete. View at Source ↗

⁨Comment⁩ on ⁨Introducing the unified new view for the topic list⁩ ⁨⁨17⁩ ⁨hours⁩ ago⁩:
It just felt like a lot of text to show all the time to users just because they have an empty list, regardless of whether a user account was 1 day old or 10 years old…this is what we show now:

image
image984×621 70.8 KB

But there is probably a middle ground, like maybe we could show more info if the user account isn’t very old, or we could add more info in a tooltip? @awesomerobot WDYT?

Overall we still have to do more work on user tips/new user education, hopefully at some point we can get to this.
Introducing the unified new view for the topic listmeta.discourse.org ↗
Submitted ⁨⁨1⁩ ⁨day⁩ ago⁩ to ⁨Announcements@meta.discourse.org⁩ | ⁨10⁩ ⁨comments⁩
⁨Comment⁩ on ⁨Granular group-based permissions for anonymous and logged in users⁩ ⁨⁨2⁩ ⁨days⁩ ago⁩:
Looking at these components, currentUser?.groups is not reliable anyway, since it only includes visible groups for the user, and the groups that they are in that impact permissions may not be serialized here:
github.com/discourse/discourse
app/serializers/current_user_serializer.rb

ba3e2d766
```
      
          def groups
            owned_group_ids = GroupUser.where(user_id: id, owner: true).pluck(:group_id).to_set
          
            object
              .visible_groups
              .pluck(:id, :name, :has_messages)
              .map do |id, name, has_messages|
                group = { id: id, name: name, has_messages: has_messages }
                group[:owner] = true if owned_group_ids.include?(id)
                group
              end
          end
      
    
```
We get around this in core/plugins by doing stuff like this in the current user serializer:
github.com/discourse/discourse
app/serializers/current_user_serializer.rb

ba3e2d766
```
      
          def can_delete_all_posts_and_topics
            object.in_any_groups?(SiteSetting.delete_all_posts_and_topics_allowed_groups_map)
          end
      
    
```
But obviously, this is not available to theme components/themes and their settings.

Image Moin:

The problem is that everyone changes to ‘logged_in_users’ even though I specifically selected it. Do I need to create a custom migration for this so that admins currently using everyone will continue to have filters for unregistered users in the future? When does this migration need to take place? Or does every admin need to change this individually after you have run the migration?

Hmm not sure, will have to think about this. If you truly meant everyone, then it would need to change to both logged_in_users AND anonymous_users . This was the main problem with everyone as stated in the OP – some people took it to mean only logged in users, others took it to mean logged in + anon, and it was very situation-dependent.

I chose the “only logged in users” interpretation because that was safer from a security POV.

Image Moin:

It feels like I’m overlooking something important. After all, the change has been enabled by default for almost a week now. That’s why I assume that official components would already have been updated if adjustments were necessary.

Nope, just didn’t think about theme components/themes and their settings and how they would be impacted by this change, I was mostly focused on site settings. Stuff like this especially will be very hard to find, since it’s not even using the AUTO_GROUPS const:

image

Anyway, I will think up some solutions to these issues, and I won’t move this change along to Stable until I figure them out.
⁨Comment⁩ on ⁨Granular group-based permissions for anonymous and logged in users⁩ ⁨⁨4⁩ ⁨weeks⁩ ago⁩:

Image Jagster:

Wait… what :flushed_face: Does that mean all categories that are now public (everyone)

No, because:

Image martin:

What about tag and category permissions?

These permissions will be unchanged, since their concept of “everyone” is different in a few ways and doesn’t rely on the underlying automatic group.

This only affects group list type site settings that currently allow you to select “everyone” like so:

image
image909×273 54 KB
Granular group-based permissions for anonymous and logged in usersmeta.discourse.org ↗
Submitted ⁨⁨4⁩ ⁨weeks⁩ ago⁩ to ⁨Announcements@meta.discourse.org⁩ | ⁨5⁩ ⁨comments⁩