Comment on Is there a place where you can request code reviews on opensource software?

• lysdexic@programming.dev ⁨11⁩ ⁨months⁩ ago

  See also the C4 process RFC

  What an unfortunate name.

  c4model.com

  source
• onlinepersona@programming.dev ⁨11⁩ ⁨months⁩ ago

  mbin (fork of kbin) is currently trying to implement the process.

  source

  • stifle867@programming.dev ⁨11⁩ ⁨months⁩ ago

    It’s great to see the attempt and also an example of what the C4 guidelines are made to avoid.

    Notice how many comments are little nitpicks about this and that. Completely stalling the commit and getting further away from the original point of C4 which is to reduce contributor friction and avoid these kind of endless discussions on PRs.

    I don’t want to be too critical because some of that is a clear lack of understanding of the motivations of C4 which is explained more thoroughly in Pieter’s blog posts. You don’t want to adopt a contributor guidelines that you don’t understand of course.

    IMO it’s better just to implement it as-is and start using it in practice rather than bikeshedding.

    source

    • onlinepersona@programming.dev ⁨11⁩ ⁨months⁩ ago

      Feel free to make that comment there.

      source

      • stifle867@programming.dev ⁨11⁩ ⁨months⁩ ago

        I would have but I don’t want to tie my Lemmy account to my actual identity :/

        source