Comment on While reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?

<- View Parent
wicked@programming.dev ⁨1⁩ ⁨year⁩ ago

Your answer doesn’t give confidence that you care about how the code looks. Could imply that you’re sloppy. Some people are very opiniated about style and think it matters a lot. They would be unhappy with people who say it doesn’t really matter.

They’d likely welcome fixes or comments on style. Other people would be very angry if you held up their PR with such trivialities.

I had strong style preferences when I was younger, but after working on so many projects with different styles I really don’t care anymore about any particular style. I just make sure to seamlessly match the style of the code around it.

source
Sort:hotnewtop