To be clear: the president dictating it via executive order is unconstitutional, not the practice of voter id itself.
The constitution pretty explicitly makes elections a state issue with some congressional action on top of them. The president doesn’t factor into it