This kind of “manual” alignment should be avoided for many reasons including the fact that adding/removing/changing of one parameter here may force you to modify multiple lines which on it’s own is annoying but this will also show up in the diff during review making it harder to grep what was actually changed.
Comment on Tabs are objectively better than spaces - gomakethings.com
wgs@lemmy.sdf.org 1 year agoWhen I talk about alignment it’s not about function arguments, but values, “=” signs and such. You simply cannot use tabs for that because alignment must be fixed and indentation independent:
CreateOrderRequest( user, productDetails. => order.detail, pricingCalculator. => DEFAULT_CALCULATOR, order => order.internalNumber)
PHLAK@lemmy.world 1 year ago
wgs@lemmy.sdf.org 1 year ago
I personally favor code readability over patch readability. But I reckon this is a matter of preference so I can understand how you might not like that.
catastrophicblues@lemmy.ca 1 year ago
Yeah I agree I don’t find alignment very useful. It’s more work for dubious benefit, and god forbid you change one of the lines.
realharo@lemm.ee 1 year ago
I normally avoid that too, I find it hurts readability more than helps, plus a proper IDE will separate it by color anyway.
wgs@lemmy.sdf.org 1 year ago
To each their own indeed. But my rule of thumb is: only use tabs when there’s no other character before it (aka, start of line).
natecox@programming.dev 1 year ago
The emacs wiki agrees and has the correct take on this: www.emacswiki.org/emacs/SmartTabs
It seems like this basic guideline, tabs to indent and spaces to align, solves the problem for everyone. It doesn’t matter what your tab width is, it’ll look “right” regardless.